lightning: port RangeSplitter #46447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lance6716 <lance6716@gmail.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46447 +/- ##
================================================
- Coverage 73.4238% 73.2837% -0.1402%
================================================
Files 1299 1337 +38
Lines 394037 408612 +14575
================================================
+ Hits 289317 299446 +10129
- Misses 86339 90805 +4466
+ Partials 18381 18361 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: lance6716 <lance6716@gmail.com>
ti-chi-bot
bot
added
size/XL
Signed-off-by: lance6716 <lance6716@gmail.com>
ti-chi-bot
bot
added
size/XXL
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
lance6716
changed the title
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
lance6716
changed the title
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
This reverts commit 1ad896d.
lance6716
changed the title
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: lance6716 <lance6716@gmail.com>
wjhuang2016
approved these changes
Sep 4, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
tangenta
approved these changes
Sep 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #45719
Problem Summary:
What is changed and how it works?
RangeSplitter can split external engine's key range into multiple range groups, and return the data files which are overlapping with the group's key range, as well as split keys which can be used to split the group into smaller ranges.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.